fix: restrict workflow_dispatch to main branch#13
Merged
TerrifiedBug merged 16 commits intomainfrom Mar 5, 2026
Merged
Conversation
- Replace "dev-unknown" fallback with null to prevent false update notifications for dev agents when version string can't be fetched - Add missing Prisma migration for latestDevAgentRelease fields - Add comment clarifying VF_CHANNEL is documentation-only
The agent infers its channel from the version string prefix (dev- vs semver). Writing VF_CHANNEL to the env file served no purpose.
Previously, checksums fetched from GitHub were only held in memory. After a server restart within the 24h cache window, the version was loaded from the DB but checksums were empty, causing agent self-update checksum verification to fail. Store checksums as JSON in SystemSettings for both stable and dev channels, and load them on cache hits.
- Always update checkedAt when dev release fetch succeeds, even if dev-version.txt is missing, to prevent GitHub API rate limit exhaustion - Add concurrency group to agent-dev-binaries CI job to prevent race conditions on concurrent pushes to main - Guard stable tag construction against null version to avoid "vnull" URL
The paths filter on the push trigger prevented CI from running when the workflow file itself was modified in a merge commit (GitHub evaluates against the pre-merge workflow). Removing it ensures dev binary builds run on every push to main, matching the design intent. Also adds workflow_dispatch for manual triggering.
The push-gated jobs (images, dev binaries) excluded workflow_dispatch events, so manual triggers only ran lint. Now all build jobs run on both push and workflow_dispatch.
Prevent manual dispatches from feature branches from overwriting the dev release and Docker images with non-main code.
Greptile SummaryThis PR adds a
Confidence Score: 5/5
Last reviewed commit: d51655c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchbuilds torefs/heads/mainonlydevpre-release with non-main codeTest plan
gh workflow run ci.yml --ref maintriggers all build jobsgh workflow run ci.yml --ref feat/some-branchonly runs lint